Refactor identifier handling: replace Provider and Subject fields with a single Key field in Identifier struct, update related message structures, and adjust parsing logic

services/data_service/internal/server/gprc_control_server.go

@@ -18,9 +18,7 @@ type GRPCControlServer struct {
 }
 
 func NewGRPCControlServer(m *manager.Manager) *GRPCControlServer {
-	return &GRPCControlServer{
-		manager: m,
-	}
+	return &GRPCControlServer{manager: m}
 }
 
 func (s *GRPCControlServer) StartStream(_ context.Context, _ *pb.StartStreamRequest) (*pb.StartStreamResponse, error) {
@@ -28,7 +26,6 @@ func (s *GRPCControlServer) StartStream(_ context.Context, _ *pb.StartStreamRequ
 	if err != nil {
 		return nil, fmt.Errorf("failed to start stream: %w", err)
 	}
-
 	return &pb.StartStreamResponse{StreamUuid: streamID.String()}, nil
 }
 
@@ -38,19 +35,18 @@ func (s *GRPCControlServer) ConfigureStream(_ context.Context, req *pb.Configure
 		return nil, status.Errorf(codes.InvalidArgument, "invalid stream_uuid %q: %v", req.StreamUuid, err)
 	}
 
-	// Transform identifiers from protobuf to domain format
 	var ids []domain.Identifier
-	for _, i := range req.Identifiers {
-		ids = append(ids, domain.Identifier{
-			Provider: i.Provider,
-			Subject:  i.Subject,
-		})
+	for _, in := range req.Identifiers {
+		id, e := domain.ParseIdentifier(in.Key)
+		if e != nil {
+			return nil, status.Errorf(codes.InvalidArgument, "invalid identifier %q: %v", in.Key, e)
+		}
+		ids = append(ids, id)
 	}
 
 	if err := s.manager.ConfigureStream(streamID, ids); err != nil {
 		return nil, status.Errorf(codes.InvalidArgument, "configure failed: %v", err)
 	}
-
 	return &pb.ConfigureStreamResponse{}, nil
 }
 
@@ -59,11 +55,8 @@ func (s *GRPCControlServer) StopStream(_ context.Context, req *pb.StopStreamRequ
 	if err != nil {
 		return nil, status.Errorf(codes.InvalidArgument, "invalid stream_uuid %q: %v", req.StreamUuid, err)
 	}
-
-	err = s.manager.StopStream(streamID) // Should only error if the stream doesn't exist
-	if err != nil {
+	if err := s.manager.StopStream(streamID); err != nil {
 		return nil, status.Errorf(codes.Internal, "failed to stop stream: %v", err)
 	}
-
 	return &pb.StopStreamResponse{}, nil
 }